[luv-legion-650] Clear the undici advisories and land Dependabot #641-#649 - #650
Conversation
The Supply Chain (OSV-Scanner) gate was red on every open PR, including all nine Dependabot bumps, on a finding none of them introduced: five undici advisories published after main's last green scan. undici is transitive under the jsdom test environment and already pinned via `overrides` from the previous round of this same fix (#446), so the repair is a one-line bump of that pin to 7.29.0. With the shared blocker gone, the nine bumps are folded in here rather than merged one at a time: #641 actions/download-artifact 4 -> 8 #642 docker/login-action 4.5.1 -> 4.6.0 #643 actions/upload-artifact 4 -> 7 #644 posthog-node 5.46.1 -> 5.47.7 #645 jsdom 30.0.0 -> 30.0.1 #646 @tanstack/react-virtual 3.14.8 -> 3.14.9 #647 lucide-react 1.27.0 -> 1.28.0 #648 @types/node 26.1.1 -> 26.1.2 #649 @vitejs/plugin-react 6.0.3 -> 6.0.5 The two artifact actions are major bumps and have to land together, because build-daemon.yml uploads the failproofaid-* binaries that publish.yml downloads. Every input in use was checked against each target's action.yml rather than assumed: name/path/if-no-files-found and pattern/path/merge-multiple all survive, and the new `archive` input defaults to true so the zip round trip is unchanged. translate-docs.yml was already on v7/v8, so this leaves the repo on one major instead of straddling two. Verified with CI's own scanner image (osv-scanner-action:v2.3.8) against the updated lockfile: No issues found, exit 0, with osv-scanner.toml still holding zero ignored vulnerabilities. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013zdtoUrNwGKm7ZYpQTdBZy
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
The entries were written while the fix sat on the failproofaid branch; it now ships as its own PR. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013zdtoUrNwGKm7ZYpQTdBZy
Every open PR in the repo was red on the Supply Chain (OSV-Scanner) gate —
including all nine open Dependabot bumps, none of which touch the package that
was failing. This clears the shared blocker and folds those nine bumps in.
Based on
failproofaidand targeted at it, since #632 is the branch currentlycarrying release work and needs the gate green.
The blocker: five
undiciadvisoriesundici@7.28.0picked up five advisories that published aftermain's lastgreen scan, so every branch went red at once with no dependency change of its
own:
=inCache-ControlsetCookietypeAll five are fixed in 7.29.0.
undiciis not a direct dependency — itarrives transitively under the
jsdomtest environment — and the 7.28.0 pin wasitself the previous round of this same fix (#446), so the repair is a one-line
bump of that existing
overridesentry rather than a lockfile update. Fixingrather than allow-listing, per
osv-scanner.toml's stated preference.Same shape as the
brace-expansionfix on #632 and thenext/sharpincidentbefore it (#591).
Folding in Dependabot #641–#649
With the shared blocker gone, each of these was red on that finding and nothing
of its own, so they land here rather than as nine separate merges:
actions/download-artifact4 → 8docker/login-action4.5.1 → 4.6.0actions/upload-artifact4 → 7posthog-node5.46.1 → 5.47.7jsdom30.0.0 → 30.0.1@tanstack/react-virtual3.14.8 → 3.14.9lucide-react1.27.0 → 1.28.0@types/node26.1.1 → 26.1.2@vitejs/plugin-react6.0.3 → 6.0.5The npm bumps move their declared floors too, so the tree cannot resolve back.
Those six packages plus their transitive companions (
@posthog/core,@posthog/types,@tanstack/virtual-core) are the only entries thelockfile moves — verified against the diff, no incidental drift.
The two artifact actions have to land together
build-daemon.ymluploads thefailproofaid-*binaries thatpublish.ymldownloads, so bumping one major without the other would split the release path
across two versions. Rather than assume the majors are drop-in, every input in
use was checked against each target's
action.yml:name,path,if-no-files-foundall survive; the newarchiveinput defaults totrue, so the artifact is still zipped.pattern,path,merge-multipleall survive;skip-decompressdefaults to
false, so the zip round trip is unchanged.Both carry a
node24runtime.translate-docs.ymlwas already on v7/v8, sothis leaves the repo on one major instead of straddling two.
docker/login-actionstays SHA-pinned (dbcb8138…, verified against the v4.6.0tag), as that workflow pins all of its actions.
Verification
ghcr.io/google/osv-scanner-action:v2.3.8) runagainst the updated lockfile:
No issues found, exit 0 — withosv-scanner.tomlstill holding zero ignored vulnerabilities. The sameimage against the pre-fix lockfile reproduces the CI failure exactly
(2 packages, 6 vulnerabilities).
bun run lint(0 errors,the same 5 pre-existing warnings),
tsc --noEmitclean,bun run test:run,bun run build,bun run test:e2e— all green.failproofaidand ran a full green CIsweep there (all 17 checks, including
OSV-Scanner, all fourcross-compile legs, and
test-e2e) before being moved onto this branch.#641–#649 are closed in favour of this PR.
🤖 Generated with Claude Code
https://claude.ai/code/session_013zdtoUrNwGKm7ZYpQTdBZy